Skip to content

Prevent release-tag injection in docs deployment - #1

Open
sbillig wants to merge 2 commits into
mainfrom
fix/deploy-tag-injection
Open

sbillig wants to merge 2 commits into
mainfrom
fix/deploy-tag-injection

Conversation

@sbillig

@sbillig sbillig commented Sep 23, 2026

Copy link
Copy Markdown

A crafted release tag can reach make deploy VERSION=..., where Make previously interpolated the value into shell recipes. Preserve version and tag inputs literally, validate release syntax before use, and pass values to quoted shell variables. Regression tests cover normal deployment and Make/shell substitution attempts.

Related to argotorg/fe#1565.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T18:27:20.069050Z c6147ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6147ef451

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Makefile
Comment on lines +82 to 83
@jq --arg v "$$VERSION" \
'if (.versions | index($$v)) then . else .versions += [$$v] end | .latest = ([.versions[] | select(test("^[0-9]+\\.[0-9]+\\.[0-9]+$$"))] | sort_by(split(".") | map(tonumber)) | last // .versions[0])' \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle an initial prerelease when choosing latest

When versions.json has no stable versions, deploying a permitted prerelease or build-metadata version fails here with Cannot index array with string "versions". After the inner pipeline reaches last, the fallback .versions[0] is evaluated against that pipeline's array rather than the root object, so the command exits after creating the version artifacts but leaves versions.json unchanged. The new test misses this because it always deploys a stable version before the prerelease.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant