fix: remove x-sourcemap header

darrachequesne · darrachequesne · commit a4dffc6527f4 · 2021-07-04T00:51:41.000+02:00
This header is useless, as the client bundle already contains a sourceMappingURL field. Besides, Firefox prints the following warning: > <url> is being assigned a //# sourceMappingURL, but already has one Related: socketio#3958
diff --git a/lib/index.ts b/lib/index.ts
@@ -515,9 +515,6 @@ export class Server<
     );
     res.setHeader("ETag", expectedEtag);
 
-    if (!isMap) {
-      res.setHeader("X-SourceMap", filename.substring(1) + ".map");
-    }
     Server.sendFile(filename, req, res);
   }
 
diff --git a/test/socket.io.ts b/test/socket.io.ts
@@ -59,7 +59,7 @@ describe("socket.io", () => {
             if (err) return done(err);
             expect(res.headers["content-type"]).to.be("application/javascript");
             expect(res.headers.etag).to.be('"' + clientVersion + '"');
-            expect(res.headers["x-sourcemap"]).to.be(filename + ".map");
+            expect(res.headers["x-sourcemap"]).to.be(undefined);
             expect(res.text).to.match(/engine\.io/);
             expect(res.status).to.be(200);
             done();

Original file line number	Diff line number	Diff line change
`@@ -515,9 +515,6 @@ export class Server<`
`515`	`515`	`);`
`516`	`516`	`res.setHeader("ETag", expectedEtag);`
`517`	`517`
`518`		`- if (!isMap) {`
`519`		`- res.setHeader("X-SourceMap", filename.substring(1) + ".map");`
`520`		`- }`
`521`	`518`	`Server.sendFile(filename, req, res);`
`522`	`519`	`}`
`523`	`520`