fix: fix io.except() method

darrachequesne · darrachequesne · commit 94e27cd072c8 · 2021-07-10T11:48:46.000+02:00
Previously, calling `io.except("theroom").emit(...)` did not exclude the sockets in the given room. This method was forgotten in [1]. [1]: socketio@ac9e8ca
diff --git a/lib/index.ts b/lib/index.ts
@@ -700,11 +700,8 @@ export class Server<
    * @return self
    * @public
    */
-  public except(
-    name: Room | Room[]
-  ): Server<ListenEvents, EmitEvents, ServerSideEvents> {
-    this.sockets.except(name);
-    return this;
+  public except(name: Room | Room[]): BroadcastOperator<EmitEvents> {
+    return this.sockets.except(name);
   }
 
   /**
diff --git a/test/socket.io.ts b/test/socket.io.ts
@@ -836,6 +836,27 @@ describe("socket.io", () => {
     });
 
     it("should exclude a specific socket when emitting", (done) => {
+      const srv = createServer();
+      const io = new Server(srv);
+
+      srv.listen(() => {
+        const socket1 = client(srv, "/");
+        const socket2 = client(srv, "/");
+
+        socket2.on("a", () => {
+          done(new Error("should not happen"));
+        });
+        socket1.on("a", () => {
+          done();
+        });
+
+        socket2.on("connect", () => {
+          io.except(socket2.id).emit("a");
+        });
+      });
+    });
+
+    it("should exclude a specific socket when emitting (in a namespace)", (done) => {
       const srv = createServer();
       const sio = new Server(srv);
 
