Merged
Conversation
Owner
|
Thank you for reporting this and for the fix. I'm sorry for answering years later; I had to take a long hiatus from maintaining this package for personal reasons, and I also struggled to understand your fix. For future reference, I'm gonna add an explanation below: When the Node Stream API invokes the We remember this condition by setting the |
fbbdev
added a commit
that referenced
this pull request
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a problem when sending some larger HTTP packets (a file upload) to this FastCGI server. For some reason, the
"data"event would only fire once and the rest of the data would be buffered and not emitted. This single line fixed the issue, by setting_canPushto true, even if no data is buffered. A call to_readis a signal that more data is requested and that more data can therefore be pushed.