Skip to content

update pygfx pin #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clewis7 merged 3 commits into from
Nov 14, 2025
Merged

update pygfx pin #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57cbade
update pygfx pin
kushalkolar Nov 12, 2025
8d64bf9
Fix screenshot logic
almarklein Nov 13, 2025
59e5ffc
new pin
almarklein Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions examples/tests/test_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,29 +100,10 @@ def test_example_screenshots(module, prep_environment):
# import the example module
example = import_from_path(module.stem, module)

if fpl.IMGUI:
# there doesn't seem to be a resize event for the manual offscreen canvas
example.figure.imgui_renderer._backend.io.display_size = (
example.figure.canvas.get_logical_size()
)
# run this once so any edge widgets set their sizes and therefore the subplots get the correct rect
# hacky but it works for now
example.figure.imgui_renderer.render()

example.figure._fpl_reset_layout()
# render each subplot
for subplot in example.figure:
subplot.viewport.render(subplot.scene, subplot.camera)

# flush pygfx renderer
example.figure.renderer.flush()

if fpl.IMGUI:
# render imgui
example.figure.imgui_renderer.render()

# render a frame
img = np.asarray(example.figure.renderer.target.draw())
# Render a frame. Twice, because layouts don't settle in one go?
m1 = example.figure.renderer.target.draw()
m2 = example.figure.renderer.target.draw()
img = np.asarray(m2)

# check if _something_ was rendered
assert img is not None and img.size > 0
Expand Down Expand Up @@ -164,7 +145,6 @@ def test_example_screenshots(module, prep_environment):
ref_img = normalize_image(ref_img)

similar, rmse = image_similarity(rgb, ref_img)

update_diffs(module.stem, similar, rgb, ref_img)
assert similar, (
f"diff {rmse} above threshold for {module.stem}, see "
Expand Down Expand Up @@ -206,7 +186,9 @@ def get_diffs_rgba(slicer):


if __name__ == "__main__":
os.environ["RENDERCANVAS_FORCE_OFFSCREEN"] = "true"
os.environ["PYGFX_DEFAULT_PPAA"] = "none"
test_examples_run("simple")
test_example_screenshots("simple")
# Need to apply these env vars *before* running this script,
# since FPL selects its backend on import.
# os.environ["RENDERCANVAS_FORCE_OFFSCREEN"] = "true"
# os.environ["PYGFX_DEFAULT_PPAA"] = "none"

test_example_screenshots(examples_to_test[0], None)
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ keywords = [
requires-python = ">= 3.10"
dependencies = [
"numpy>=1.23.0",
"pygfx==0.15",
"pygfx==0.15.3",
"wgpu", # Let pygfx constrain the wgpu version
"cmap>=0.1.3",
# (this comment keeps this list multiline in VSCode)
Expand Down