Skip to content

fewer github actions for CI #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clewis7 merged 1 commit into from
Oct 21, 2025
+13 −11
Merged

fewer github actions for CI #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci-pygfx-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI
name: CI-pygfx-release

on:
push:
Expand All @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ["3.11", "3.12", "3.13"]
python: ["3.11", "3.13"]
imgui_dep: ["imgui", ""]
notebook_dep: ["notebook", ""]
os: ["ubuntu-latest", "macos-latest"]
Expand Down Expand Up @@ -63,19 +63,20 @@ jobs:
run: |
pytest -v tests/
- name: Test examples
if: ${{ matrix.python == '3.13' }}
env:
RENDERCANVAS_FORCE_OFFSCREEN: 1
run: |
pytest -v examples/
- name: Test examples notebooks, exclude ImageWidget notebook
if: ${{ matrix.notebook_dep == 'notebook' }}
if: ${{ matrix.notebook_dep == 'notebook' && matrix.python == '3.13' }}
env:
FASTPLOTLIB_NB_TESTS: 1
# test notebooks, exclude ImageWidget notebooks
run: pytest --nbmake $(find ./examples/notebooks/ -maxdepth 1 -type f -name "*.ipynb" ! -name "image_widget*.ipynb" -print | xargs)
- name: Test ImageWidget notebooks
- name: Test ImageWidget notebook
# test image widget notebooks only if imgui is installed
if: ${{ matrix.notebook_dep == 'notebook' && matrix.imgui_dep == 'imgui' }}
if: ${{ matrix.notebook_dep == 'notebook' && matrix.imgui_dep == 'imgui' && matrix.python == '3.13' }}
env:
FASTPLOTLIB_NB_TESTS: 1
run: pytest --nbmake $(find ./examples/notebooks/ -maxdepth 1 -type f -name "image_widget*.ipynb" -print | xargs)
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI
name: CI-pygfx-main

on:
push:
Expand All @@ -15,13 +15,13 @@ on:

jobs:
test-build-full:
name: Tests
name: Tests - pygfx main
timeout-minutes: 20
if: ${{ !github.event.pull_request.draft }}
strategy:
fail-fast: false
matrix:
python: ["3.11", "3.12", "3.13"]
python: ["3.11", "3.13"]
imgui_dep: ["imgui", ""]
notebook_dep: ["notebook", ""]
os: ["ubuntu-latest", "macos-latest"]
Expand Down Expand Up @@ -69,19 +69,20 @@ jobs:
run: |
pytest -v tests/
- name: Test examples
if: ${{ matrix.python == '3.13' }}
env:
RENDERCANVAS_FORCE_OFFSCREEN: 1
run: |
pytest -v examples/
- name: Test examples notebooks, exclude ImageWidget notebook
if: ${{ matrix.notebook_dep == 'notebook' }}
if: ${{ matrix.notebook_dep == 'notebook' && matrix.python == '3.13' }}
env:
FASTPLOTLIB_NB_TESTS: 1
# test notebooks, exclude ImageWidget notebooks
run: pytest --nbmake $(find ./examples/notebooks/ -maxdepth 1 -type f -name "*.ipynb" ! -name "image_widget*.ipynb" -print | xargs)
- name: Test ImageWidget notebooks
- name: Test ImageWidget notebook
# test image widget notebooks only if imgui is installed
if: ${{ matrix.notebook_dep == 'notebook' && matrix.imgui_dep == 'imgui' }}
if: ${{ matrix.notebook_dep == 'notebook' && matrix.imgui_dep == 'imgui' && matrix.python == '3.13' }}
env:
FASTPLOTLIB_NB_TESTS: 1
run: pytest --nbmake $(find ./examples/notebooks/ -maxdepth 1 -type f -name "image_widget*.ipynb" -print | xargs)
Expand Down