Allow use of `add_*_selector` methods in `ScatterGraphic` by lkeegan · Pull Request #883 · fastplotlib/fastplotlib

lkeegan · 2025-07-21T14:03:52Z

move these existing methods from LineGraphic to common base clase PositionsGraphic
regenerate docs

- move these existing methods from `LineGraphic` to common base clase `PositionsGraphic` - regenerate docs

kushalkolar · 2025-07-21T14:22:43Z

Hi thanks for your PR!

Supporting selections for scatters will also require implementing the methods to get data from the selections, for example with the rectangle selector:

fastplotlib/fastplotlib/graphics/selectors/_rectangle.py

Line 295 in dac31cf

def get_selected_data(

fastplotlib/fastplotlib/graphics/selectors/_rectangle.py

Line 423 in dac31cf

def get_selected_indices(

I'm not sure what a linear or linear region selector means for a scatter, do you have a use case example? I can maybe see the usecase for exploring regression plots.

lkeegan · 2025-07-22T08:04:19Z

Hi thanks for your PR!

Supporting selections for scatters will also require implementing the methods to get data from the selections, for example with the rectangle selector:

fastplotlib/fastplotlib/graphics/selectors/_rectangle.py

Line 295 in dac31cf

def get_selected_data(

fastplotlib/fastplotlib/graphics/selectors/_rectangle.py

Line 423 in dac31cf

def get_selected_indices(

Thanks for your feedback - and for this very nice library! I'll look into updating these methods.

I'm not sure what a linear or linear region selector means for a scatter, do you have a use case example? I can maybe see the usecase for exploring regression plots.

I guess if one axis in the scatter is time it could make sense to select a time range of data using the linear region selector.
My personal use case is very basic - I just want to be able to select a time on linked plots of time series data, e.g. a line plot of voltage traces and a scatter plot of features extracted from these traces:

plots.mp4

…xamples

clewis7

Hi @lkeegan

Thanks again for making a PR! I had a few small questions/tweaks. I'm sure @kushalkolar will also want to take a look. I checked out your examples, and they look great!

clewis7 · 2025-07-22T18:42:23Z

fastplotlib/graphics/_positions_base.py


        # min/max limits
-        limits = (x_axis_vals[0], x_axis_vals[-1], ymin * 1.5, ymax * 1.5)
+        limits = (xmin, xmax, ymin, ymax)


Why did you remove the ymin * 1.5 and ymax * 1.5? I think we had that there to allow the selector to go a little bit above and below the graphic.

Ah sorry - I removed it because with positive ymin the limits didn't allow you to select all the data, restored in 75b7d73

clewis7 · 2025-07-22T18:43:44Z

fastplotlib/graphics/_positions_base.py

+        axis_vals_min = np.floor(axis_vals.min()).astype(int)
+        axis_vals_max = np.floor(axis_vals.max()).astype(int)
+
+        bounds_init = axis_vals_min, axis_vals_min + 0.25 * (
+            axis_vals_max - axis_vals_min
+        )
+        limits = axis_vals_min, axis_vals_max


Can you add code comments here?

sure: c5ec080

…e unused variables

…rk when ymin is positive

clewis7 · 2025-07-23T12:54:09Z

@kushalkolar LGTM as long as the examples pass

kushalkolar · 2025-07-29T02:17:25Z

I'm going to wait until #837 is merged first since that changes some things with selectors.

…xample for it

lkeegan · 2025-09-30T07:05:01Z

@kushalkolar I've updated this PR to include the polygon selector from #837

kushalkolar · 2025-10-01T00:26:24Z

Thanks for the update! I'll try this out and merge after #904 so that I don't have to replace the ground truth screenshots multiple times, it will be merged soon! 😄

kushalkolar · 2025-10-01T00:29:26Z

fastplotlib/graphics/selectors/_polygon.py

        self._resizable = bool(resizable)

        BaseSelector.__init__(self, name=name, parent=parent)
-        self._move_info = MoveInfo("none", -1, -1, None, None)


@almarklein I'm guessing this was a typo? 😆

I don't think so, the type of MoveInfo.mode was str. Though in _end_move_mode I did set it to None, so I was not consistent 😆.

So this change looks fine to me, especially with the type now also being mode: str | None.

kushalkolar · 2025-10-01T00:32:51Z

fastplotlib/graphics/scatter.py

+        xmin = np.floor(x_axis_vals.min()).astype(int)
+        xmax = np.ceil(x_axis_vals.max()).astype(int)
+
+        # min/max limits include the data + 25% padding in the y-direction


might want to pad in both x and y for a scatter?

yes that makes sense

kushalkolar · 2025-10-01T00:35:56Z

examples/selection_tools/linear_region_scatter.py

+LinearRegionSelector which selects along the x-axis and a vertical selector which moves along the y-axis.
+"""
+
+# test_example = false


make this true, we'd want to have a ground truth screenshot for this since it's a new feature.

kushalkolar · 2025-10-01T00:36:02Z

examples/selection_tools/polygon_selector_scatter.py

+Example showing how to use a `PolygonSelector` with a scatter plot.
+"""
+
+# test_example = false


make this true, we'd want to have a ground truth screenshot for this since it's a new feature.

kushalkolar · 2025-10-01T00:36:13Z

examples/selection_tools/rectangle_selector_scatter.py

+Example showing how to use a `RectangleSelector` with a scatter plot.
+"""
+
+# test_example = false


make this true, we'd want to have a ground truth screenshot for this since it's a new feature.

…etting selection to complete selection

lkeegan · 2025-11-10T14:31:48Z

@kushalkolar thanks for reviewing, I've made the suggested changes and merged the latest changes from the main branch

kushalkolar · 2025-11-10T14:39:31Z

Thanks I haven't forgotten this! We're just very busy with other parts of the library at the moment.

…

On Mon, Nov 10, 2025, 09:33 Liam Keegan ***@***.***> wrote: *lkeegan* left a comment (fastplotlib/fastplotlib#883) <#883 (comment)> @kushalkolar <https://github.com/kushalkolar> thanks for reviewing, I've made the suggested changes and merged the latest changes from the main branch — Reply to this email directly, view it on GitHub <#883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXXRCGFODJ34AGDBLM2YL34CO5DAVCNFSM6AAAAACB76T6VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMJSGA2DOMRRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

kushalkolar

Some comments, sorry for the late response, lots of stuff on our plate lately

examples/selection_tools/linear_region_scatter.py

fastplotlib/graphics/selectors/_polygon.py

kushalkolar · 2026-01-30T08:00:47Z

fastplotlib/graphics/selectors/_linear_region.py

                return source.data[s]

+        if "Scatter" in source.__class__.__name__:
+            return source.data[ixs]


Is this always valid for an arbitrary scatter? What if we have a blob, like a Gaussian cloud? I think it's only valid for scatters that represent data which are a function of the x or y dim?

I think it's valid for any scatter data - it just returns the subset of data in the selected region:

fastplotlib/graphics/selectors/_rectangle.py

kushalkolar · 2026-01-30T08:06:05Z

fastplotlib/graphics/_positions_base.py


        self._size_space = SizeSpace(size_space)
        super().__init__(*args, **kwargs)
+


Can you update this w.r.t. the current methods

Done in 6e5b923

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>

…to support negative y-axis values)

Allow use of add_*_selector methods in ScatterGraphic

acab9d0

- move these existing methods from `LineGraphic` to common base clase `PositionsGraphic` - regenerate docs

lkeegan requested review from clewis7 and kushalkolar as code owners July 21, 2025 14:03

Update linear/rectangle selectors to work with ScatterGraphics, add e…

5ae771e

…xamples

clewis7 reviewed Jul 22, 2025

View reviewed changes

lkeegan added 2 commits July 23, 2025 08:06

refactor bounds_init logic to make intent clearer, add comment, remov…

c5ec080

…e unused variables

restore y-padding on rectangle selector limits, refactored to also wo…

75b7d73

…rk when ymin is positive

lkeegan added 2 commits September 29, 2025 11:20

Merge branch 'main' into scatter_graphic_add_linear_selector

c28163f

Add add_polygon_selector method to ScatterGraphic and create an e…

e2d6b9f

…xample for it

kushalkolar reviewed Oct 1, 2025

View reviewed changes

kushalkolar mentioned this pull request Oct 1, 2025

add ImageVolumeGraphic #791

Merged

14 tasks

lkeegan added 4 commits October 1, 2025 16:00

allow selection to extend by 25% padding in all directions

8776b29

enable ground truth screenshots for scatter selector examples

7898ad2

set initial polygon selection in example and reset _move_info after s…

82870b9

…etting selection to complete selection

Merge branch 'main' into scatter_graphic_add_linear_selector

9054ae0

kushalkolar requested changes Jan 30, 2026

View reviewed changes

lkeegan and others added 5 commits January 30, 2026 09:43

Update fastplotlib/graphics/selectors/_polygon.py

2b607b5

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>

Update fastplotlib/graphics/selectors/_rectangle.py

5313a05

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>

Update fastplotlib/graphics/selectors/_polygon.py

481138b

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>

run black on examples/selection_tools/linear_region_scatter.py

41c3a02

Merge branch 'main' into scatter_graphic_add_linear_selector

4db8d34

lkeegan added 3 commits January 30, 2026 10:00

update add_*_selector to match main branch (keeping previous changes …

6e5b923

…to support negative y-axis values)

fix typos

4598ae0

Add sizes to linear region scatter example

b0720b4

lkeegan requested a review from kushalkolar January 30, 2026 10:59


		self._size_space = SizeSpace(size_space)
		super().__init__(args, *kwargs)

Conversation

lkeegan commented Jul 21, 2025

Uh oh!

kushalkolar commented Jul 21, 2025

Uh oh!

lkeegan commented Jul 22, 2025

Uh oh!

clewis7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clewis7 commented Jul 23, 2025

Uh oh!

kushalkolar commented Jul 29, 2025

Uh oh!

lkeegan commented Sep 30, 2025

Uh oh!

kushalkolar commented Oct 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lkeegan commented Nov 10, 2025

Uh oh!

kushalkolar commented Nov 10, 2025 via email

Uh oh!

kushalkolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants