fix typo in the requested limit name of the wgpu device#679
fix typo in the requested limit name of the wgpu device#679kushalkolar merged 7 commits intofastplotlib:extinguish-firesfrom
Conversation
|
Thanks! Looks like this change in wgpu is now in the release: pygfx/wgpu-py#617 |
|
Nice find! This explains why there were no errors before. I didn't think to look at the issue tracker of pygfx. |
|
test failures are due to pygfx/wgpu-py#644, need to wait for the next release of wgpu with pygfx/wgpu-py#645 |
|
If you can update the test as well it should be good to go! https://github.com/fastplotlib/fastplotlib/actions/runs/11975376261/job/33491202021?pr=679#step:8:24 |
|
That should be ok, all tests pass on my machine, with pygfx installed from its main branch, to be aligned with the CI setup : Do you think that the required pygfx version should be updated too, in the setup.py? |
|
Sorry, there are still some errors. I will investigate ... |
…hen for the other limits.
|
Looks like there are no imgui wheels for python 3.10 so it's trying to build but it requires |
…eel for imgui-bundle.
|
Thanks. I've added the installation of |
|
had to update the CI timeout, it takes longer since it has to build imgui 1.5.2 for python 3.10. Anyways this PR will fix all those issues: pygfx/wgpu-py#649 |
|
ok now it looks like the latest release of pyav 14 hours ago breaks imageio https://github.com/PyAV-Org/PyAV/releases posted in imageio: imageio/imageio#1111 |
|
ok, no problem, so we just have to wait I guess. |
|
I'm going to merge this into a temporary branch where we're updating things w.r.t. upstream changes like #686 where we're switching from pyav to ffmpeg. |
* use imageio[ffmpeg] instead of pyav (#686) * fix typo in the requested limit name of the wgpu device (#679) * fix typo in the requested limit name of the wgpu device. * fix test config. * fix examples/test and docs * fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits. * fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle. * update CI timeout * update timeout in non-nb test job --------- Co-authored-by: Kushal Kolar <kushalkolar@gmail.com> * update to use pygfx.TextureMap * forgot to set imageio[ffmpeg] for all extras * migrate to RenderCanvas, remove event_filter stuff for imgui since that was fixed in pygfx * remove very old irrelevant example * fix docstring * update examples to use fpl.loop.run() * update API docs * black * import ImageWidget only if imgui is installed * enumerate_adapters() -> enumerate_adapters_sync() * remove annoying warnings from cmap * remove more cmap warnings * black --------- Co-authored-by: Jérémie Fache <jeremie.fache@netcourrier.com>
* use imageio[ffmpeg] instead of pyav (fastplotlib#686) * fix typo in the requested limit name of the wgpu device (fastplotlib#679) * fix typo in the requested limit name of the wgpu device. * fix test config. * fix examples/test and docs * fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits. * fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle. * update CI timeout * update timeout in non-nb test job --------- Co-authored-by: Kushal Kolar <kushalkolar@gmail.com> * update to use pygfx.TextureMap * forgot to set imageio[ffmpeg] for all extras * migrate to RenderCanvas, remove event_filter stuff for imgui since that was fixed in pygfx * remove very old irrelevant example * fix docstring * update examples to use fpl.loop.run() * update API docs * black * import ImageWidget only if imgui is installed * enumerate_adapters() -> enumerate_adapters_sync() * remove annoying warnings from cmap * remove more cmap warnings * black --------- Co-authored-by: Jérémie Fache <jeremie.fache@netcourrier.com>
2 participants
Hi,
when running different examples involving images, the following exception is raised:
It fails for the following examples (non-exhaustive list), on windows10, python 3.12.6, pygfx 0.6.0, wgpu 0.19.1 (can't test right now on linux because of an error related to imgui):
I believe there's a typo in the string passed to the
limitsproperty of thewgpu.Deviceobject. From the wgpu documentation (Rust), the constant is named 'max_texture_dimension_2d', at least since wgpu-0.10.1:https://docs.rs/wgpu/latest/wgpu/struct.Limits.html#structfield.max_texture_dimension_2d
By appling the lower-case style, the examples now work by adding an hyphen before "2d". I don't know if it is specific to my setup, but this fix seems to be aligned with the wgpu API.