Skip to content

env var required for nb test funcs to run #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalkolar merged 1 commit into from
Mar 30, 2024
Merged

env var required for nb test funcs to run #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
PYGFX_EXPECT_LAVAPIPE: true
run: |
pytest -v examples
pytest --nbmake examples/notebooks/
FASTPLOTLIB_NB_TESTS=1 pytest --nbmake examples/notebooks/
- uses: actions/upload-artifact@v3
if: ${{ failure() }}
with:
Expand Down
15 changes: 15 additions & 0 deletions examples/notebooks/nb_test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,19 @@
FAILURES = list()


def _run_tests():
if "FASTPLOTLIB_NB_TESTS" not in os.environ.keys():
return False

if os.environ["FASTPLOTLIB_NB_TESTS"] == "1":
return True

return False


def plot_test(name, plot: Union[Plot, GridPlot]):
if not _run_tests():
return
snapshot = plot.canvas.snapshot()

if "REGENERATE_SCREENSHOTS" in os.environ.keys():
Expand Down Expand Up @@ -81,6 +93,9 @@ def get_diffs_rgba(slicer):


def notebook_finished():
if not _run_tests():
return

if len(FAILURES) > 0:
raise AssertionError(
f"Failures for plots:\n{FAILURES}"
Expand Down