Repository navigation
fix: accept null for nullable tuple items - #908
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
itemsis a list of schemas, each item is checked withbuildArrayTypeCondition()before it is serialized. That check ignoresnullable, so a tuple item such as{ type: 'integer', nullable: true }throwsItem at 0 does not match schema definition.fornull. A nullable singleitemsschema or object property already acceptsnull.This change adds
buildTupleItemCondition(), which letsnullthrough when the item schema hasnullable: true.buildValue()already serializes it asnull. Both the inlined and the function-wrapped tuple paths use the new helper. Non-nullable tuple items still rejectnull.Fixes #907
Checklist
npm run test && npm run benchmark --if-present(tests pass; benchmark not run)and the Code of conduct