Allow passing csrf cookie args in FastApiUsers.get_oauth_router#1552
Merged
frankie567 merged 2 commits intofastapi-users:masterfrom Dec 19, 2025
Merged
Allow passing csrf cookie args in FastApiUsers.get_oauth_router#1552frankie567 merged 2 commits intofastapi-users:masterfrom
frankie567 merged 2 commits intofastapi-users:masterfrom
Conversation
Member
|
Right, very great catch! Thank you 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 991 991
=========================================
Hits 991 991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@all-contributors add @jthurner for bug |
Contributor
|
I've put up a pull request to add @jthurner! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oauth CSRF-cookie added in 7cf413c is configurable through
router.oauth.get_oauth_router, but the arguments are not passed through fromFastApiUsers.get_oauth_routerwhich is the recommended way to create the routes.The PR simply adds the new arguments to the
get_oauth_routerfunction on the mainFastApiUsersobject. Currently this means their default values are defined in two places, you might prefer to remove them fromrouter.oauth.get_oauth_router().