Security Fix: Open Redirect Vulnerability in Delete Endpoints#185
Open
crit0x90 wants to merge 1 commit intofastapi-admin:devfrom
Open
Security Fix: Open Redirect Vulnerability in Delete Endpoints#185crit0x90 wants to merge 1 commit intofastapi-admin:devfrom
crit0x90 wants to merge 1 commit intofastapi-admin:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a security vulnerability where the delete endpoints were using the HTTP Referer header without validation, which could lead to open redirect attacks.
Changes Made
get_safe_redirect_urlfunction that validates redirect URLsdeleteandbulk_deleteendpoints to use this functionSecurity Impact
This change prevents attackers from redirecting users to malicious sites after delete operations, which could be exploited for phishing attacks.
Testing
I've tested this fix by:
Fixes #184