🚨 Fix Type of "Field" is partially unknown with Pyright in strict mode#1644
🚨 Fix Type of "Field" is partially unknown with Pyright in strict mode#1644mpyuglgwkxcmodyrpo wants to merge 1 commit intofastapi:mainfrom
Type of "Field" is partially unknown with Pyright in strict mode#1644Conversation
|
This is a more suitable alternative to #1604 as it keeps the |
YuriiMotov
changed the title
Type of "Field" is partially unknown with Pyright in strict mode
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
This fixes the issue and solution looks good to me.
To reproduce the issue, create main.py with:
# pyright: strict
from sqlmodel import FieldAnd run:
pip install pyright
pyright main.py@mpyuglgwkxcmodyrpo, thanks!
|
That's awesome! I hope the version with these changes gets released soon. |
|
@tiangolo @YuriiMotov I'm wondering when this PR will be added to the release. |
github-actions
bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
|
This pull request has a merge conflict that needs to be resolved. |
|
I have confirmed that the issue has been resolved in the newly released |
Thanks! @mpyuglgwkxcmodyrpo, thank you for your efforts! |
3 participants
See #1598 for discussion. I wanted to see if this would pass tests across the matrix (don't see why they wouldn't).
I think this only applies to pyright in strict mode.
I can't edit lables, so someone should add the bug label or whatever else is relevant.