📝 Update define relationships attributes docs: Optional[Team] -> Team | None#1070
Closed
scku208 wants to merge 2 commits intofastapi:mainfrom
Closed
📝 Update define relationships attributes docs: Optional[Team] -> Team | None#1070scku208 wants to merge 2 commits intofastapi:mainfrom
Optional[Team] -> Team | None#1070scku208 wants to merge 2 commits intofastapi:mainfrom
Conversation
Contributor
|
📝 Docs preview for commit e4eebb0 at: https://e9394122.sqlmodel.pages.dev Modified Pages |
Author
|
I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None) |
alejsdev
changed the title
Optional[Team] -> Team | NoneOptional[Team] -> Team | None
Contributor
|
📝 Docs preview for commit a12d320 at: https://e04f716f.sqlmodel.pages.dev Modified Pages |
@scku208 could you update the PR with this change so we can get this ready to be merged? |
Member
|
Thanks! This was covered in #1351, so I'll close this one now. 🤓 ☕ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users new to SQLModel, the documentation might be confusing. It is recommended to focus on explanations for Python 3.10+ or to include additional parenthetical notes explaining differences from earlier versions.