♻️ Avoid creating an intermediate container in get_value_or_default for efficiency
#14233
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a items tuple by combining first_items with extra_items and is not used in the reminder of the code. To make it more efficient we can check the items directly
arun-geek
changed the title
YuriiMotov
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
@arun-geek, thanks for your interest!
It was probably made this way to reduce the code duplication (if not isinstance(first_item, DefaultPlaceholder)).
The performance impact of this change is very tiny - this function is only called several times per route on application startup.
I don't think we should focus on such micro-optimizations, but let's Sebastian decide.
YuriiMotov
changed the title
get_value_or_default for efficiency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to improve efficiency of the code
create a items tuple by combining first_items with extra_items and is not used in the reminder of the code. To make it more efficient we can check the items directly