Deps: Update core to v0.6#836
Merged
Merged
Conversation
sedited
force-pushed
the
updateCore
branch
4 times, most recently
from
2da20ff to
e2d2585
Compare
sedited
force-pushed
the
updateCore
branch
2 times, most recently
from
f6924bd to
2916df3
Compare
sedited
force-pushed
the
updateCore
branch
2 times, most recently
from
e51aa76 to
d75844e
Compare
This includes a massive rename of `Offer` into `Deal`. s/PublicOffer/Deal/ s/PublicOffer.Offer/Deal.Parameters/ Also, the swap id and the deal id now have the same underlying type, allowing us to track the entire lifetime of a swap from a made deal to a swap outcome.
h4sh3d
reviewed
Dec 15, 2022
h4sh3d
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a massive rename of
OfferintoDeal.s/PublicOffer/Deal/
s/PublicOffer.Offer/Deal.Parameters/
Also, the swap id and the deal id now have the same underlying type, allowing us to track the entire lifetime of a swap from a made deal to a swap outcome.