State machines: Add Executor trait#705
Merged
Merged
Conversation
sedited
force-pushed
the
stateExecutor
branch
3 times, most recently
from
af618ff to
704ae6e
Compare
Adds an executor trait that is useful for a common operation involving state machines: Creating an event and calling next on the state machine and logging its results.
h4sh3d
added
the
farcaster.dev testing
h4sh3d
approved these changes
Oct 17, 2022
Member
h4sh3d
left a comment
h4sh3d
left a comment
There was a problem hiding this comment.
tACK
Good refactor, the 2 functions were basically the same. Tested the PR is equivalent feature wise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an executor trait that is useful for a common operation involving state machines: Creating an event and calling next on the state machine and logging its results.
Based on #693