Fix /compose and Dockerfile#685
Conversation
- remove farcaster:compose tag - move `docker-compose.yml` to `/compose` - fix `environment` key in `docker-compose.yml` - use `farcasterd`'s `latest` tag instead of `compose` tag in `docker-compose.yml` - add volume from `/compose` to `/var/lib/farcaster` - add `/compose/.farcaster` to `.gitignore`
|
I'll do more tests before approve and merge, but concept ACK. Also we we'll have to check to update documentation in wiki. |
|
@h4sh3d cool. I tried to fix the |
h4sh3d
left a comment
h4sh3d
left a comment
There was a problem hiding this comment.
I was working on the doc anyway so I did the update.
Now the docker stack is better, using :latest is good but we have to complete improvements on the release process and create releases more often so latest doesn't point to a month old node.
E.g. locally I switched latest to main so I get the updates.
2 participants
Changes:
.github/workflows/create-compose-release.yml/compose/Dockerfileenvironmentkey in/compose/docker-compose.ymldocker-compose.ymlto/composefolder/Dockerfile's CMD by removing the-xand--data-dirarguments; the-xargument was giving the errorerror: Invalid value "lnpz://0.0.0.0:9981/?api=esb" for '--ctl-socket <CTL_SOCKET>': invalid server address string 'lnpz://0.0.0.0:9981/?api=esb', and the--data-dirargument was givingthread 'main' panicked at 'Unable to access data directory: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }'src/opts.rs:133:42/compose/docker-compose.ymluses the latestfarcasterdtag and creates a volume from/composeto/var/lib/farcaster, so that thecompose/farcasterd.tomlcan be usedPlease test it, too! :)