Skip to content

Add Support for Python 3.8#306

Merged
faif merged 6 commits intofaif:masterfrom
duboviy:patch-1
Oct 17, 2019
Merged

Add Support for Python 3.8#306
faif merged 6 commits intofaif:masterfrom
duboviy:patch-1

Conversation

@duboviy
Copy link
Copy Markdown
Contributor

@duboviy duboviy commented Oct 17, 2019

No description provided.

@gyermolenko
Copy link
Copy Markdown
Contributor

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

@duboviy
Copy link
Copy Markdown
Contributor Author

duboviy commented Oct 17, 2019

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

Thanks a lot @gyermolenko ! I've tried it - works like a charm!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 17, 2019

Codecov Report

Merging #306 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   32.82%   32.46%   -0.36%     
==========================================
  Files          42       42              
  Lines        1496     1534      +38     
==========================================
+ Hits          491      498       +7     
- Misses       1005     1036      +31
Impacted Files Coverage Δ
patterns/structural/mvc.py 0% <0%> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py2.py 0% <0%> (ø) ⬆️
patterns/other/blackboard__py3.py 0% <0%> (ø) ⬆️
patterns/behavioral/catalog.py 0% <0%> (ø) ⬆️
patterns/behavioral/memento.py 0% <0%> (ø) ⬆️
patterns/structural/flyweight__py2.py 0% <0%> (ø) ⬆️
patterns/behavioral/registry__py3.py 0% <0%> (ø) ⬆️
patterns/behavioral/registry__py2.py 0% <0%> (ø) ⬆️
patterns/other/blackboard__py2.py 0% <0%> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py3.py 0% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13574b...a916b09. Read the comment docs.

@faif faif merged commit 24c876d into faif:master Oct 17, 2019
@duboviy duboviy deleted the patch-1 branch October 17, 2019 21:24
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.46%. Comparing base (e13574b) to head (a916b09).
⚠️ Report is 275 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   32.82%   32.46%   -0.36%     
==========================================
  Files          42       42              
  Lines        1496     1534      +38     
==========================================
+ Hits          491      498       +7     
- Misses       1005     1036      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants