Skip to content

Combine and refine dependency injection patterns - #285

Merged
faif merged 3 commits into
faif:masterfrom
gyermolenko:fix_constructor_inj_pattern
Mar 5, 2019
Merged

Combine and refine dependency injection patterns#285
faif merged 3 commits into
faif:masterfrom
gyermolenko:fix_constructor_inj_pattern

Conversation

@gyermolenko

@gyermolenko gyermolenko commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

ref #284

What this PR does:

  • combine dependency injection patterns into one file since they have a lot of common boilerplate
  • add tests (and remove old ones)
  • turn injected classes into functions
  • update description
  • update readme

@codecov-io

codecov-io commented Mar 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #285 into master will decrease coverage by 0.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #285     +/-   ##
=========================================
- Coverage   72.99%   72.19%   -0.8%     
=========================================
  Files          62       57      -5     
  Lines        2177     2115     -62     
=========================================
- Hits         1589     1527     -62     
  Misses        588      588
Impacted Files Coverage Δ
patterns/dependency_injection.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e9bfc...fe7d3a1. Read the comment docs.

@faif
faif merged commit fe3c21b into faif:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants