Skip to content

Fix some PEP8 issues#240

Merged
faif merged 1 commit intofaif:masterfrom
jounderwood:pep8-fix
Sep 17, 2018
Merged

Fix some PEP8 issues#240
faif merged 1 commit intofaif:masterfrom
jounderwood:pep8-fix

Conversation

@jounderwood
Copy link
Contributor

Just some PEP8 fixes with https://github.com/ambv/black

 black -S -l 120 .

@0--key
Copy link
Contributor

0--key commented Sep 17, 2018

It's a great job, guys, but why you're choose such huge line length (120)?

@jounderwood
Copy link
Contributor Author

@0--key, There is 45 lines that bigger than 80 and I think usage of 80 symbols will decrease readability. Plus honestly I chose 120, because my IDE (pycharm) has such setting by default and it's really convenient

flake8 --exclude .venv . | grep "line too long" | wc -l
45

@faif
Copy link
Owner

faif commented Sep 17, 2018

@0--key I don't think that 120 characters is a huge length for modern monitors. On the contrary, I find 80 too short, a UNIX legacy holding since the teletype times...

@faif faif merged commit 312530d into faif:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants