Update decorator.py #194
Merged
Update decorator.py #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would extend the decorator from the base class. The reason is that we still expect an italic bold text to be a text! So we expect the behaviours of the basic TextTag class to exists in the class that is being decorated. Example: If you add the following method to the TextTag class, you expect your decorated objects still be able to call that method:
```
def say_hello():
print 'hello I am text!'
```
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 61 61
Lines 2430 2430
=======================================
Hits 2302 2302
Misses 128 128
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would extend the decorator from the base class. The reason is that we still expect an italic bold text to be a text! So we expect the behaviours of the basic TextTag class to exists in the class that is being decorated. Example: If you add the following method to the TextTag class, you expect your decorated objects still be able to call that method: