New repository structure; Resolve issue #165#166
Merged
faif merged 11 commits intofaif:masterfrom Jan 4, 2017
duboviy:master
Merged
New repository structure; Resolve issue #165#166faif merged 11 commits intofaif:masterfrom duboviy:master
faif merged 11 commits intofaif:masterfrom
duboviy:master
Conversation
… package in tests
|
Looks like a good idea 👍 Category-folder GoF book classification is really needed here because each pattern is under a category in the repo's README So looks good to me! |
Closed
Owner
|
@duboviy There's a conflict in |
tim-burton
approved these changes
Jan 2, 2017
Current coverage is 93.90% (diff: 100%)@@ master #166 diff @@
==========================================
Files 48 48
Lines 2198 2198
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2064 2064
Misses 134 134
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
To improve readability I've structured this repository in packages (creational, structural, behavioral, other).
This pull request should resolve enhancement issue #165.
Also I've added in README lacking patterns that were lost there:
P.S.
All tests and CI is fixed and working fine for me in my fork, here are kind of proof links :) :
My CI evidence 1
My CI evidence 2