This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[WoW] Update teachers to use DialogTeacher#4284
Merged
Merged
Conversation
mojtaba-komeili
approved these changes
Jan 5, 2022
mojtaba-komeili
left a comment
mojtaba-komeili
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just make sure you address the lint errors.
|
This PR has not had activity in 30 days. Closing due to staleness. |
Contributor
|
Let's rebase? |
Contributor
|
Merge in main |
Contributor
Author
|
could i please get a quick re-review from either of you @stephenroller @mojtaba-komeili ? |
stephenroller
approved these changes
Mar 30, 2022
stephenroller
left a comment
stephenroller
left a comment
Contributor
There was a problem hiding this comment.
Looks perfect. Expect strong speedups in our fine tuning runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch description
See title --> updating the WoW teachers to use
DialogTeacherTesting steps
Banking on CI here