This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Eliminate dummy batches and init_cuda_buffer.#3732
Merged
Conversation
klshuster
approved these changes
Jun 21, 2021
klshuster
left a comment
klshuster
left a comment
Contributor
There was a problem hiding this comment.
thanks for making this change. I'm approving but did have one perhaps pertinent question
| Cache a batch to be used as a dummy during _fake_forward_pass. | ||
| """ | ||
| if not hasattr(self, '_dummy_batch'): | ||
| self._dummy_batch = batch |
Contributor
There was a problem hiding this comment.
does this unnecessarily use up memory? what if the first batch is huge for example?
Contributor
Author
There was a problem hiding this comment.
Could be a worse problem for images. For text, imagine it's a 2x2048x1024 LongTensor (2x for content and label; bs 2048; string length 1024). A long is 8 bytes. So we'll be wasting 32MiB of memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch description
Eliminate the dreaded
_dummy_batchand_init_cuda_buffer.Users have complained about the presence of these methods. When debugging, the first batch being a dummy causes some confusion (why am I getting gibberish data?) and the manual implementation of a
_dummy_batchis annoying (why is my model breaking on the first pass?)Adopt Fairseq's newer approach:
Testing steps
CI.