Add enable&disable breakpoints by rg-expression. by sunbohong · Pull Request #230 · facebook/chisel

sunbohong · 2018-02-23T12:19:50Z

No description provided.

kastiglione

Thanks for the contribution, this is a cool command.

kastiglione · 2018-02-26T18:23:19Z

+
+  br_list = listStr.splitlines()
+  expression_pattern = re.compile(r'{}'.format(expression),re.I)
+  id_pattern = re.compile(r'^\s*([1-9]\d*)(\.\d+)?',re.I)


What do you think about using the Python API, instead of parsing the output of breakpoint list?

For example, it would roughly look like:

for breakpoint in target.breakpoint_iter(): for location in breakpoint: if pattern.search(location.GetAddress().symbol.name): location.SetEnabled(False)

target = lldb.debugger.GetSelectedTarget() for breakpoint in target.breakpoint_iter(): for location in breakpoint: if expression_pattern.search('{}'.format(location)): location.SetEnabled(on)

What do you think about using location?
They have some different.

location 2.1: where = SunLigth`__66+[SUNNetService httpAsyncPostWithDictionary:completionBlock:]_block_invoke + 1984 at SUNNetService.m:37, address = 0x0000000104514dfc, unresolved, hit count = 0 Options: disabled address SunLigth`__66+[SUNNetService httpAsyncPostWithDictionary:completionBlock:]_block_invoke + 1984 at SUNNetService.m:37 symbol id = {0x00006db1}, range = [0x00000001001e063c-0x00000001001e0ec8), mangled="__66+[SUNNetService httpAsyncPostWithDictionary:completionBlock:]_block_invoke" name __66+[SUNNetService httpAsyncPostWithDictionary:completionBlock:]_block_invoke

So that,we can use benable disabled to switch all breakpoints to enable,and also as follow

#use `benable disabled` to switch all breakpoints to `enable` benable disabled * benable ***address*** benable 0x0000000104514dfc * benable ***filename*** benable SUNNetService.m * benable ***module*** benable UIKit benable SunLigth

Enabling/disabling via filename and module definitely seem useful!

kastiglione · 2018-02-26T18:26:19Z

+    return 'benable'
+
+  def description(self):
+    return "Enable a set of breakpoints for a relative expression"


typo: should be "regular", not "relative"

kastiglione · 2018-02-26T18:26:21Z

+
+class FBMethodBreakpointEnableCommand(fb.FBCommand):
+  def name(self):
+    return 'benable'


lldb has an alias command named rb for regex breakpoint. I think it makes sense to call this rbenable and rbdisable, what do you think?

kastiglione · 2018-02-28T21:53:26Z


+def switchBreakpointState(expression,on):
+  ci = lldb.debugger.GetCommandInterpreter()
+  res = lldb.SBCommandReturnObject()


These two lines are no longer used.

kastiglione · 2018-02-28T21:53:50Z

+  ci = lldb.debugger.GetCommandInterpreter()
+  res = lldb.SBCommandReturnObject()
+
+  expression_pattern = re.compile(r'{}'.format(expression),re.I)


This can be re.compile(expression, re.I)

kastiglione · 2018-02-28T21:55:37Z

+  target = lldb.debugger.GetSelectedTarget()
+  for breakpoint in target.breakpoint_iter():
+    for location in breakpoint:
+      if expression_pattern.search('{}'.format(location)):


This also doesn't need the format, I think it can be just .search(str(location)).

kastiglione · 2018-02-28T21:55:55Z

+  for breakpoint in target.breakpoint_iter():
+    for location in breakpoint:
+      if expression_pattern.search('{}'.format(location)):
+        print location


Nice addition 👍

kastiglione · 2018-02-28T21:57:02Z

+
+          #use `rbenable ***module(AppName)***` to switch all breakpoints in this module to `enable`
+          benable UIKit
+          benable Foundation 


This documentation block uses benable where it should be rbenable.

kastiglione · 2018-02-28T21:58:23Z

+    Examples:
+
+          #use `rbenable disabled` to switch all breakpoints to `enable`
+          benable disabled


This doesn't appear to be implemented. I don't think it's necessary to implement, since br dis (breakpoint disable) does this already.

since br dis (breakpoint disable)has already this.
Should we use location.GetAddress() to search?

location 57.1: where = libsystem_kernel.dylib`mach_msg_trap + 4, address = 0x00000001832ef564, resolved, hit count = 0 address libsystem_kernel.dylib`mach_msg_trap + 4 symbol id = {0x0000024e}, range = [0x000000018095b560-0x000000018095b56c), name="mach_msg_trap" name mach_msg_trap

when i set breakpoint at this address(0x0000024e),only symbol contain 0x0000024e.
So i want search address and symbol.How do you think?

What does id = {0x0000024e} represent? The address of the breakpoint is in the location: address = 0x00000001832ef564.

i am sorry.i mean that i want search 0x1832ef564 ,not 0x00000001832ef564

Do you mean you want rbdisable 0x1832ef564 to disable the breakpoint whose address is 0x00000001832ef564?

Maybe add special cased input handling. If the user's input expression matches 0x[[:xdigit:]], then when building the regex, add a 0* after the 0x. So 0x1832ef564 would become 0x0*1832ef564.

kastiglione · 2018-02-28T22:00:06Z

@sunbohong I have just a few more small comments. Once those are resolved, I will merge this pull request. Thanks again.

kastiglione · 2018-03-02T17:46:38Z

@sunbohong after thinking about it a little bit, I think benable and bdisable are good names for these commands. Disabling by address isn't really a regular expression, and I have an idea or two for extensions to this command, which are also not for regular expressions. One command I've built for myself in the past is to disable the current breakpoint when stopped, and I think bdisable is a good place to add that functionality.

kastiglione · 2018-03-06T13:30:21Z

+    Examples:
+
+          #use `benable disabled` to switch all breakpoints to `enable`
+          benable disabled


I don't think this should be documented. A builtin command already does this: breakpoint enable (or br en for short).

kastiglione · 2018-03-06T13:31:11Z

+    Examples:
+
+          #use `bdisable disabled` to switch all breakpoints to `disable`
+          bdisable disabled


Likewise, this is builtin.

ok,i will remove it

kastiglione · 2018-03-06T18:17:39Z

+  for breakpoint in target.breakpoint_iter():
+    if breakpoint.IsEnabled() != on and (expression_pattern.search(str(breakpoint))):
+      print str(breakpoint)
+      breakpoint.SetEnabled(on)      


Did you find this was necessary in your experience? I'm curious what are some example cases where these commands need to apply to the breakpoint itself instead of working only on the locations.

If we use br disable 41 to off 41,and benable 41 only enable locations's state.
The 41 41.1 will be ignore.

kastiglione · 2018-03-07T07:06:41Z

Thanks @sunbohong!

Add enable&disable breakpoints by rg-expression.

a21a3ca

facebook-github-bot added the CLA Signed label Feb 23, 2018

kastiglione reviewed Feb 26, 2018

View reviewed changes

sunbohong added 2 commits February 28, 2018 14:26

Update rbdisable & rbenable

ef65202

Update rbdisable & rbenable

cb2e255

kastiglione reviewed Feb 28, 2018

View reviewed changes

Update rbdisable & rbenable

a8cfd69

kastiglione self-assigned this Mar 2, 2018

sunbohong added 2 commits March 6, 2018 17:52

Update rbdisable & rbenable

80f10d0

Update bdisable&benable

8df85b6

kastiglione reviewed Mar 6, 2018

View reviewed changes

Update FBDebugCommands.py

c043070

kastiglione reviewed Mar 6, 2018

View reviewed changes

kastiglione merged commit 89297aa into facebook:master Mar 7, 2018

Conversation

sunbohong commented Feb 23, 2018

Uh oh!

kastiglione left a comment

Choose a reason for hiding this comment

Uh oh!

kastiglione Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastiglione Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastiglione Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastiglione commented Feb 28, 2018

Uh oh!

kastiglione commented Mar 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastiglione Mar 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastiglione commented Mar 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kastiglione Feb 26, 2018 •

edited

Loading

kastiglione Mar 1, 2018 •

edited

Loading

kastiglione Mar 2, 2018 •

edited

Loading

kastiglione Mar 6, 2018 •

edited

Loading