Conpherence - workflow the Message link on people profiles

bobtrahan · bobtrahan · commit ea78f920ddfb · 2013-05-01T14:42:58.000-07:00
Summary: Fixes T2416. I was tired of looking at this task in the list, interns be damned. :D Test Plan: it is now a workflow when you click it Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2416 Differential Revision: https://secure.phabricator.com/D5811
diff --git a/src/applications/conpherence/controller/ConpherenceNewController.php b/src/applications/conpherence/controller/ConpherenceNewController.php
@@ -86,24 +86,9 @@ public function processRequest() {
 
         $conpherence->saveTransaction();
 
-        if ($request->isAjax()) {
-          $dialog = id(new AphrontDialogView())
-            ->setUser($user)
-            ->setTitle('Success')
-            ->addCancelButton('#', 'Okay')
-            ->appendChild(
-              phutil_tag(
-                'p',
-                array(),
-                pht('Message sent successfully.')));
-          $response = id(new AphrontDialogResponse())
-            ->setDialog($dialog);
-        } else {
-          $uri = $this->getApplicationURI($conpherence->getID());
-          $response = id(new AphrontRedirectResponse())
-            ->setURI($uri);
-        }
-        return $response;
+        $uri = $this->getApplicationURI($conpherence->getID());
+        return id(new AphrontRedirectResponse())
+          ->setURI($uri);
       }
     }
 
diff --git a/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php b/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php
@@ -28,6 +28,7 @@ private function handleMenuEvent($event) {
       ->setIsExternal(true)
       ->setName($name)
       ->setHref($conpherence_uri)
+      ->setWorkflow(true)
       ->setKey($name));
 
     $event->setValue('menu', $menu);
