Conpherence - fix a bug

bobtrahan · bobtrahan · commit 09ed95583c81 · 2013-04-28T11:00:43.000-07:00
Summary: gotta idx() on this as the user may have no conpherences at all. Test Plan: loaded up my 'noconpherences' user and observed no errors in the error log. my normal test user still worked okay too. Reviewers: epriestley, garoevans Reviewed By: garoevans CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5791
diff --git a/src/view/page/menu/PhabricatorMainMenuView.php b/src/view/page/menu/PhabricatorMainMenuView.php
@@ -271,7 +271,7 @@ private function renderNotificationMenu() {
         ->withParticipantPHIDs(array($user->getPHID()))
         ->withParticipationStatus($unread_status)
         ->execute();
-      $message_count_number = $unread[$user->getPHID()];
+      $message_count_number = idx($unread, $user->getPHID(), 0);
       if ($message_count_number > 999) {
         $message_count_number = "\xE2\x88\x9E";
       }

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ private function renderNotificationMenu() {`
`271`	`271`	`->withParticipantPHIDs(array($user->getPHID()))`
`272`	`272`	`->withParticipationStatus($unread_status)`
`273`	`273`	`->execute();`
`274`		`- $message_count_number = $unread[$user->getPHID()];`
	`274`	`+ $message_count_number = idx($unread, $user->getPHID(), 0);`
`275`	`275`	`if ($message_count_number > 999) {`
`276`	`276`	`$message_count_number = "\xE2\x88\x9E";`
`277`	`277`	`}`