Skip to content

Fix _convert_value(..) trying to access non-existing ExtismVal.y field #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aristidebm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix _convert_value(..) trying to access non-existing ExtismVal.y field #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions extism/extism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
Optional,
Tuple,
)
from enum import Enum
from enum import IntEnum
from uuid import UUID
from extism_sys import lib as _lib, ffi as _ffi # type: ignore
import functools
Expand Down Expand Up @@ -105,7 +105,7 @@ class Error(Exception):
...


class ValType(Enum):
class ValType(IntEnum):
"""
An enumeration of all available `Wasm value types <https://docs.rs/wasmtime/latest/wasmtime/enum.ValType.html>`.

Expand Down Expand Up @@ -638,13 +638,15 @@ def __exit__(self, type, exc, traceback):


def _convert_value(x):
# x is and instance of ExtismVal
# https://github.com/extism/extism/blob/de81040c999279f04f8361b7684d5d0af487394f/runtime/src/sdk.rs#L32
if x.t == 0:
return Val(ValType.I32, x.v.i32)
elif x.t == 1:
return Val(ValType.I64, x.v.i64)
elif x.t == 2:
return Val(ValType.F32, x.v.f32)
elif x.y == 3:
elif x.t == 3:
return Val(ValType.F64, x.v.f64)
return None

Expand Down