fix: bug in host function return values#34
Merged
chrisdickinson merged 1 commit intomainfrom Jan 29, 2025
Merged
Conversation
Contributor
|
This is addressing #33 |
zshipko
suggested changes
Jan 28, 2025
Contributor
zshipko
left a comment
zshipko
left a comment
There was a problem hiding this comment.
The changes look good but I think you will need to run just format to fix CI
chrisdickinson
force-pushed
the
chris/20250127-emplacement-bug
branch
from
a429650 to
abd42dd
Compare
Author
|
(Ooh, good catch – thanks; reformatted and re-pushed!) |
zshipko
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an incompatibility between the rust-pdk and python-sdk when using type inferred host functions. Specifically, the python-sdk was trying to return the integer value directly instead of allocating kernel memory.