Merged
Conversation
Add `extism.CompiledPlugin`, which may be provided as the `wasm` parameter to `extism.Plugin`.
Author
|
(Tests will fail until we cut a new release of extism/extism!) |
zshipko
approved these changes
Nov 26, 2024
Contributor
There was a problem hiding this comment.
From reading through it looks good - I couldn't figure out how to run the tests locally with a custom built extism-sys, but if you were able to confirm these changes then feel free to merge. Otherwise we can just wait until the next libextism release.
Author
|
Thanks for the review! I tested via: ~/extism/extism-maturin $ git rev-parse --short HEAD
4db57de
~/extism/extism-maturin $ maturin build -i python3.11
🔗 Found cffi bindings
🐍 Using CPython 3.11 at /opt/homebrew/opt/python@3.11/bin/python3.11 to generate the cffi bindings
📡 Using build options bindings from pyproject.toml
💻 Using `MACOSX_DEPLOYMENT_TARGET=11.0` for aarch64-apple-darwin by default
Compiling extism v0.0.0+replaced-by-ci (~/extism/runtime)
Compiling extism-sys v0.0.0+replaced-by-ci (~/extism/extism-maturin)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.00s
💼 Using the existing header at ~/extism/target/header.h
📦 Built wheel to ~/extism/target/wheels/extism_sys-0.0.0+replaced.by.ci-py3-none-macosx_11_0_arm64.whl
~/extism/extism-maturin $ cd ../python-sdk
~/python-sdk $ rm -f uv.lock && uv add --force-reinstall ~/extism/target/wheels/extism_sys-0.0.0+replaced.by.ci-py3-none-macosx_11_0_arm64.whl
~/python-sdk $ uv run python -m unittest discover
.............
----------------------------------------------------------------------
Ran 13 tests in 1.738s
OK
I might run a libextism patch release tomorrow just to boot out those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
extism.CompiledPlugin, which may be provided as thewasmparameter toextism.Plugin.