Merged
Conversation
The newest version of `extism_plugin_new` consumes function metadata generated by `extism_function_new`. Move the `extism_function_new` call to plugin instantiation time to fix this. Additionally, edit `pyproject.toml` to support running with `uv`.
0c402b1 to
4e5051d
Compare
zshipko
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newest version of
extism_plugin_newconsumes function metadata generated byextism_function_new. Move theextism_function_newcall to plugin instantiation time to fix this.Additionally, edit
pyproject.tomlto support running withuv.