Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: expressjs/compression
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: expressjs/compression
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: legacy-node
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 7 files changed
  • 4 contributors

Commits on Feb 14, 2025

  1. Configuration menu
    Copy the full SHA
    841c7f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb29cff View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. refactor: remove obsolete brotli and http2 support checks (#221)

    * refactor: remove obsolete brotli and http2 support checks
    
    * fix(docs): remove note about brotli support
    Phillip9587 authored Apr 7, 2025
    Configuration menu
    Copy the full SHA
    fc2ff9b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2025

  1. Configuration menu
    Copy the full SHA
    21ab1b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2025

  1. Configuration menu
    Copy the full SHA
    f1b3e1c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. Do not swallow calls to res.end() (#188)

    * Add tests demonstrating scenarios under which the original res.end does not get called
    
    * Ensure stream gets closed and response gets ended when it is finished
    
    * Only call the original res.end() a single time
    
    * Avoid using the on-finished package
    
    * Use finished() helper from node:stream
    
    * Import finished() helper directly from node:stream
    
    Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
    
    * Use finished() helper directly instead of nodeStream.finished()
    
    * Adjust stream pause / resume logic instead of messing with res.end() calls directly
    
    * Revert addition of endOnce() wrapper
    
    * Add unit test around one more alternate sequence of events that seems reasonable to test in addition to the other ones
    
    * Add test around avoiding 'write after end' errors
    
    * Avoid writing into the response after it is finished
    
    * Add a comment explaining why the compression stream gets resumed when the response finishes
    
    * chore: use isFinished of on-finished
    
    ---------
    
    Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
    martinslota and bjohansebas authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    fbb806c View commit details
    Browse the repository at this point in the history
  2. Change res.flush to accept a callback function argument (#227)

    * Change res.flush to accept a callback function argument
    
    * test: add callback invocation check for flush in brotli compression
    
    * fix lint
    
    * deps: update mocha to version 10.8.2 and add --exit option
    
    ---------
    
    Co-authored-by: Bijoy Thomas <bijoyjth@gmail.com>
    bjohansebas and bijoythomas authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    e2abcbf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9af4f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a62f50a View commit details
    Browse the repository at this point in the history
Loading