Fix custom Markdown fixture by preloading JavaScript for nested fences#430
Merged
hippotastic merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
✅ Deploy Preview for expressive-code ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky custom grammar test fixture. This was caused by a missing
embeddedLangsLazyvalue in the custom grammar, not an actual EC bug.Astro's parallel page rendering does not guarantee the order of pages during rendering. This caused the flakiness:
embeddedLangsLazyvalue, the JS grammar did not get loaded at all and was rendered as plain text, causing the test to fail.Lesson learned: It's important to properly add all languages included by custom grammars to the
embeddedLangsLazyarray, or ensure otherwise that they get loaded, e.g. by adding them to thelangsarray in case of other custom languages.