[Roman Numerals] Draft of Approaches #3605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think my latest changes get the directory structure about right, and linting now passes. There are still a small number of TODOs in the markdown. |
colinleach
changed the title
colinleach
changed the title
BethanyG
approved these changes
Jan 30, 2024
Member
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
These are all nits, so feel free to ignore any irritating ones.
The only "must change" is the TODO - otherwise, this looks good to go! 🌈 🌟
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/recurse-match/content.md
Outdated
Show resolved
Hide resolved
Member
|
Didn't register your question at first - apologies!
Would the equivalent be a |
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
…ntent.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Contributor
Author
Don't worry, I moved past that in the most recent commit. I thought about it and left it out. Feel free to add it back in if you want to, but it doesn't excite me. |
…n into approach-roman-numerals
Contributor
Author
|
With an analysis added for |
Found a mistake already
BethanyG
approved these changes
Jan 31, 2024
Member
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
Apologies for not getting to this until now. Looks good save for two small niggles. Thanks for writing this! 🌟
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md
Outdated
Show resolved
Hide resolved
Member
|
Pushing the big green button! |
petrem
pushed a commit
to petrem/exercism--python
that referenced
this pull request
Dec 22, 2025
* [Roman Numerals] early draft of approaches * updated approach documents, many changes * fixed typos and other glitches * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/recurse-match/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/introduction.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/recurse-match/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Update exercises/practice/roman-numerals/.approaches/recurse-match/content.md Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> * Fixed TODO in `itertools-starmap` * Update content.md Found a mistake already * Update content.md again * Update exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md * Update exercises/practice/roman-numerals/.approaches/itertools-starmap/content.md --------- Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't take this too seriously yet, it's clearly incomplete and I'll push updates when I have them. The empty files will also make it fail the CI checks, I expect - whatever, it's not for merging.
If you run out of rabbit holes to get lost down, take a look at the
with-itertoolsapproach. Somebody clearly had fun coming up with the most cryptic code possible, so explaining it is a challenge that I'm still working on (not as the most urgent priority).There are a couple of placeholders:
pattern-matchingfrom Scalafold-listfrom KotlinI expect we could come up with Python versions of these, but I have some doubts about whether it's worthwhile. Thoughts?