Skip to content

high-scores: update test suite to v4.0.0 (closes #1672)#1681

Merged
cmccandless merged 2 commits intoexercism:masterfrom
gabriel376:high-scores-v4.0.0
Feb 14, 2019
Merged

high-scores: update test suite to v4.0.0 (closes #1672)#1681
cmccandless merged 2 commits intoexercism:masterfrom
gabriel376:high-scores-v4.0.0

Conversation

@gabriel376
Copy link
Contributor

@gabriel376 gabriel376 commented Feb 14, 2019 •
edited
Loading

Update exercise high-scores to v4.0.0 (closes #1672)

Problem Specification

Changes:

  1. Removed report part from README
  2. Renamed function personal_top() to personal_top_three() on example.py and high_scores_test.py
  3. Removed deprecated test cases from high_scores_test.py according to problem specification
  4. Removed function report() on example.py
  5. Updated test version header to v4.0.0 on high_scores_test.py

cmccandless
cmccandless suggested changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one minor thing: I see you've attempted to link this PR to #1672, and that's great! There is actually an official way to do this: check out magic words.

Please use that to link the issue, and we should be good to go!

@gabriel376 gabriel376 changed the title high-scores: update test suite to v4.0.0 (#1672) high-scores: update test suite to v4.0.0 (closes #1672) Feb 14, 2019
@gabriel376
Copy link
Contributor Author

gabriel376 commented Feb 14, 2019

Looking good! Just one minor thing: I see you've attempted to link this PR to #1672, and that's great! There is actually an official way to do this: check out magic words.

Please use that to link the issue, and we should be good to go!

I updated title and description to use keyword closes
Do I have to update commit message too ?
Thank you!

@cmccandless
Copy link
Contributor

cmccandless commented Feb 14, 2019

I updated title and description to use keyword closes

It does no harm, but for future reference, only the description requires the keyword

Do I have to update commit message too ?

Nope, just the description. 👍

@cmccandless cmccandless merged commit 1916cc3 into exercism:master Feb 14, 2019
@cmccandless
Copy link
Contributor

cmccandless commented Feb 14, 2019

Merged; thanks for working on this!

@gabriel376
Copy link
Contributor Author

gabriel376 commented Feb 14, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cmccandless cmccandless cmccandless approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

high-scores: update tests to v4.0.0

2 participants

@gabriel376 @cmccandless