Skip to content

Conversation

@wesleydeal
Copy link
Contributor

@wesleydeal wesleydeal commented Oct 8, 2018

Add support for Python 3.7. Fix #1552

Add support for Python 3.7
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use magic words to link this PR to issue #1552

.travis.yml Outdated
sudo: true
- python: nightly
dist: trusty
sudo: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indents should be done with 2 spaces, not 4. Please correct the indentation as Travis cannot parse mixed indentation.

Fixed spacing
@wesleydeal
Copy link
Contributor Author

I've modified the spacing as requested. This should fix #1552

Apologies for the poor quality of my initial contribution, I'm still learning to work with Github.

@cmccandless
Copy link
Contributor

This should fix #1552

The magic words need to be in the PR description. Please edit the description, and add "Fix #1552" to the end.

Apologies for the poor quality of my initial contribution, I'm still learning to work with Github.

No worries! What's important is that you are here, contributing! Just make sure to always listen to feedback, but if you are confident that the feedback is incorrect, always back up your position with documentation.

@cmccandless cmccandless merged commit 65f2350 into exercism:master Oct 8, 2018
@cmccandless
Copy link
Contributor

Merged; thanks for working on this!

@wesleydeal wesleydeal deleted the patch-1 branch October 8, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants