journey test: pull in improvements from xkotlin#635
Merged
Conversation
stkent
force-pushed
the
sync-journey-test-with-xkotlin
branch
from
664c340 to
983e72c
Compare
stkent
commented
Jun 11, 2017
bin/journey-test.sh
Outdated
| for testfile in `find . -name "*Test.java"`; do | ||
| sed 's/@Ignore\(.*\)//' ${testfile} > "${tempfile}" && mv "${tempfile}" "${testfile}" | ||
| for testfile in `find . -name "*Test.${TRACK_SRC_EXT}"`; do | ||
| sed 's/@Ignore(\(.*\))?//' ${testfile} > "${tempfile}" && mv "${tempfile}" "${testfile}" |
Contributor
Author
There was a problem hiding this comment.
This is the only change I needed to make to actual functionality, because Kotlin does supply messages with ignore statements (I tried; it failed strangely; I haven't investigated further yet).
Contributor
Author
There was a problem hiding this comment.
...and that change didn't work: https://stackoverflow.com/questions/6156259/sed-expression-doesnt-allow-optional-grouped-string. Fixing now!
Contributor
Author
There was a problem hiding this comment.
Still not fixed despite appearances.
stkent
force-pushed
the
sync-journey-test-with-xkotlin
branch
from
983e72c to
5dab949
Compare
stkent
force-pushed
the
sync-journey-test-with-xkotlin
branch
from
5dab949 to
f5ddc70
Compare
FridaTveit
approved these changes
Jun 12, 2017
Contributor
FridaTveit
left a comment
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great, thanks @stkent! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the journey test file with improvements from xkotlin (mostly this involves defining configuration variables per-track up front, then reusing those variables throughout the script instead of hard-coding the track/repo name). I'll open up a similar PR in xkotlin shortly that applies these updates over there too!
Reviewer Resources:
Track Policies