Skip to content

fix token retrieval from gh cli #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
choldgraf merged 1 commit into from
Jul 9, 2023
Merged

fix token retrieval from gh cli #89

choldgraf merged 1 commit into from
Jul 9, 2023

Conversation

@minrk
Copy link
Collaborator

@minrk minrk commented Jul 8, 2023 •
edited
Loading

structure of gh auth status has changed, causing parsing to get the wrong answer

gh auth token retrieves the token without any parsing and exits with nonzero if there is no token

@minrk
fix token retrieval from gh cli
82aebfd 
structure of `gh auth status` has changed

`gh auth token` retrieves the token without any parsing and exits with nonzero if there is no token
choldgraf
choldgraf approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess this is much better

@choldgraf choldgraf merged commit e3221a3 into executablebooks:master Jul 9, 2023
@consideRatio consideRatio added the bug Something isn't working label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minrk @choldgraf @consideRatio