MAINT: Add check for installed gh cli #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @stefanv I think this would be a more helpful error in case it's not installed, sorry about that! |
stefanv
approved these changes
Jul 31, 2022
| ) | ||
| # We can't use this without auth because we hit rate limits immediately | ||
| if not auth: | ||
| raise ValueError( |
Collaborator
There was a problem hiding this comment.
This is a very helpful message, thanks!
| except FileNotFoundError: | ||
| print( | ||
| ( | ||
| "gh cli not found, so will not use it for auth. To download, " |
Collaborator
There was a problem hiding this comment.
There's the implication here that the user should install gh?
Maybe the auth checks should be printed one by one, to show what's happening under the hood.
Either way, this is an improvement, so 👍
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for whether the
ghcli is installed before trying to use it