Ensure bots propagate through concat #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
choldgraf
commented
Dec 14, 2025
| all_bot_users.update(qu.bot_users) | ||
|
|
||
| query_data = ( | ||
| pd.concat(query_data).drop_duplicates(subset=["id"]).reset_index(drop=True) |
Member
Author
There was a problem hiding this comment.
this I think was clobberying bot_users so we are now explicitly grabbing it in a set after each query
choldgraf
commented
Dec 15, 2025
Member
Author
choldgraf
left a comment
choldgraf
left a comment
There was a problem hiding this comment.
OK I gave this another look and decided it'd be safer if we added a regression test for the bot users, rather than just checking for the presence of bots. I've now done that, and caught a weird bug along the way where bots in the git commit have [bot] attached to them in a way that is different from the author username in github. So that's now accounted for, we have a regression test, and I think this works now. I'll merge this and make a release so we can get this functionality out there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this fixes #151 - I believe that the pd.concat was deleting the attrs data we were using to store bot users. I also added a test that should have bots in it so we can properly check this.