Skip to content

Properly handle branch, default to main #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
choldgraf merged 3 commits into from
Dec 14, 2025
Merged

Properly handle branch, default to main #154

choldgraf merged 3 commits into from
Dec 14, 2025

Conversation

@jtpio
Copy link
Contributor

@jtpio jtpio commented Dec 11, 2025

It looks like master was hardcoded.

Nowadays, GitHub repos default to main.

bsipocz
bsipocz approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsipocz
Copy link
Collaborator

bsipocz commented Dec 11, 2025

Some of the test failures seem related (main in the heading in the diff? I don't see why that happens from the PR diff, but something is not right).
Though I fail to see how the diff for one vs 2 contributors can be related at all.

@choldgraf
Copy link
Member

choldgraf commented Dec 14, 2025

Tests were happy on the latest pass, and this PR looks good to me so I'll merge so that we don't block this on test flakiness

@choldgraf choldgraf merged commit abff6af into executablebooks:main Dec 14, 2025
5 of 8 checks passed
@jtpio jtpio deleted the ref-branch branch December 15, 2025 06:48
@jtpio
Copy link
Contributor Author

jtpio commented Dec 15, 2025

Some of the test failures seem related (main in the heading in the diff? I don't see why that happens from the PR diff, but something is not right).

Yeah not sure either. Could it be because that some of the test data was generated before the default branch was renamed to main?
Some time ago I remember seeing some missing data when making releases with the Jupyter Releaser (which uses github-activity) for repos that switched from master to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtpio @bsipocz @choldgraf