Update test suite to use fewer GitHub API calls #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
approved these changes
Dec 1, 2025
Collaborator
|
I presume |
Collaborator
|
What does this deploy error even mean? I don't think I ever seen these types of comments from github actions before. |
Member
Author
|
OK I'm going to merge this because we aren't testing any of our PRs against the PR itself, we're just running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our test suite to use smaller date ranges etc in order to reduce the number of API calls involved in our tests. We keep hitting rate limits, which makes iteration quite difficult in this package! I tried to pick ranges that still returned data, but much less data in general so that we don't hit our limits. Most of the changes here are just to the regression tests as a result.
I don't think we can test this until it is merged, because our tests use
pull_request_targetwhich means we don't run them on the branch, but usemaininstead.@stefanv any thoughts on this? I know you ran into this too