Add a token to avoid rate limits on tests #135
Conversation
.github/workflows/tests.yaml
Outdated
| runs-on: ubuntu-24.04 | ||
| env: | ||
| # This is a private access token for @choldgraf that has public read-only access. | ||
| # WARNING: This only works for PRs from non-forked repositories. |
There was a problem hiding this comment.
This is not great then, IMO fork based workflow should be encouraged for everyone in general so to remove the "us and them" distinctions between contributors and the core team.
There was a problem hiding this comment.
(I don't necessarily say that for this repo as it should be a low traffic utility; but in general for JB)
There was a problem hiding this comment.
I agree, I am just trying to get this un-stuck here! The other option would be to re-configure out test suite so that it doesn't hit API rate limits as quickly but that feels like something I don't have the bandwidth to fix right now
choldgraf
changed the title
|
I've updated this PR so that it will revert to the old behavior if the PR is from a forked repository, that way we'll use the PAT's rate limit for non-forked calls (like releases etc) and we'll use the default github limit for all others. |
|
superceded by #134 |
This cleans up some of our token reading code and un-breaks tests in the process. Here's what this does:
TOKEN_READONLYso that we don't hit rate limits as quickly.