Ensure PRs only show up once per changelog #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
approved these changes
Aug 5, 2025
bsipocz
approved these changes
Sep 8, 2025
Collaborator
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
This looks good for the proposed functionality, though I need to mention that there are legitime reasons for a PR to be listed at multiple places, especially for more complex projects.
(The simplest case is that it changes API but also fixes bugs -- and sometimes it makes little sense to separate these changes out into multiple PRs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a pull request has multiple labels, then it'll show up in multiple sections. This isn't common practice and means that some PRs clutter up the output multiple times.
This PR makes it so that if a PR matches one label, it won't be included in any other sections. It also uses OrderedDict so that we're more confident the label ordering won't change in our logic. This should make the outputs more reliable and streamlined.