Skip to content

Conversation

@mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Mar 2, 2025

Fixes "Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release."

Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@vercel
Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Mar 2, 2025 9:48am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Mar 2, 2025 9:48am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Mar 2, 2025 9:48am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Mar 2, 2025 9:48am

@github-actions
Copy link

github-actions bot commented Mar 2, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.32% (🎯 60%) 68279 / 102940
🟢 Statements 66.32% (🎯 60%) 68279 / 102940
🟢 Functions 64.28% (🎯 63%) 1946 / 3027
🟢 Branches 79.87% (🎯 70%) 8349 / 10452
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/components/PropertiesPopover.tsx 97.91% 42.85% 100% 97.91% 49, 54
Generated in workflow #4383 for commit 71e4ce1 by the Vitest Coverage Report Action

@dwelle dwelle merged commit 2523624 into master Mar 2, 2025
11 checks passed
@dwelle dwelle deleted the mtolmacs/fix/react19-ref-prop branch March 2, 2025 13:24
Jauhen pushed a commit to Jauhen/excalidraw that referenced this pull request Mar 9, 2025
Bump @radix-ui/react-popover to fix element.ref React 19 error

Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants