Skip to content

Conversation

@mtolmacs
Copy link
Collaborator

Currently dragging elbow arrows (not start or end points!) still attempts to bind, which this PR changes to no binding in drag.

Currently elbow arrows also re-bind the opposite endpoint when the other endpoint is dragged, which can rebind to the incorrect element with overlapping binding gaps.

Also fixes #9130

@mtolmacs mtolmacs self-assigned this Feb 25, 2025
@vercel
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Mar 10, 2025 10:33am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Mar 10, 2025 10:33am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Mar 10, 2025 10:33am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 10:33am

@github-actions
Copy link

github-actions bot commented Mar 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.28% (🎯 60%) 68346 / 103111
🟢 Statements 66.28% (🎯 60%) 68346 / 103111
🟢 Functions 64.28% (🎯 63%) 1946 / 3027
🟢 Branches 79.82% (🎯 70%) 8384 / 10503
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/element/binding.ts 89.29% 88.91% 94.64% 89.29% 276, 286, 296, 306, 337, 348, 394-395, 594-596, 603-604, 607-608, 621-636, 668-669, 690-691, 758-759, 938, 982, 985-987, 990-1023, 1038-1043, 1053-1069, 1073-1095, 1099-1118, 1178-1184, 1200, 1202-1203, 1211-1216, 1255, 1442-1443, 1451-1452, 1457-1458, 1511-1512, 1537-1538, 1765-1776, 1801-1804, 1852, 1860, 2012-2013, 2124-2125, 2157-2161, 2197-2232, 2235-2244
packages/excalidraw/element/elbowArrow.ts 69.64% 84.32% 93.1% 69.64% 131-163, 179-217, 227-256, 283-457, 481, 483-484, 510, 512-529, 536, 538-555, 586, 591, 610-619, 625-634, 638-660, 664-683, 704-881, 928-935, 1068-1074, 1076-1077, 1106-1107, 1122-1125, 1127-1148, 1279, 1318, 1326-1330, 1337, 1342-1346, 1432-1433, 1436-1437, 1464-1466, 1514-1516, 1563, 1567-1568, 1603-1605, 1640-1641, 1716-1735, 1752-1756, 1768-1772, 1898-1899, 1904-1905, 1940-1941, 1953-1954, 1984-1985, 1997-1998, 2099-2108, 2150-2152
packages/excalidraw/element/flowchart.ts 91.04% 89.32% 100% 91.04% 53, 79-80, 160, 187-207, 215, 221-225, 305-306, 515-516, 616-618, 664-689
packages/excalidraw/element/mutateElement.ts 100% 100% 100% 100%
Generated in workflow #4456 for commit c33bf8d by the Vitest Coverage Report Action

@mtolmacs mtolmacs merged commit d587b8a into master Mar 10, 2025
10 checks passed
@mtolmacs mtolmacs deleted the fix/group-rebind-incorrect branch March 10, 2025 15:25
@robmcphers0n
Copy link

When will this be deployed to pro?

@mtolmacs
Copy link
Collaborator Author

There are a set of changes affecting all arrow related functionality in the works which need to marinate a little on excalidraw.com before E+ merge, so stay tuned.

@robmcphers0n
Copy link

Can you give a vague timescale?

@mtolmacs
Copy link
Collaborator Author

I expect it will be on E+ this week.

@dwelle
Copy link
Member

dwelle commented Mar 26, 2025

@robmcphers0n now released!

@robmcphers0n
Copy link

Legitimately game-changing stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elbow arrows in the group are misplaced after the whole group is moved

4 participants