-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
fix: Do not rebind undragged elbow arrow endpoint #9191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
d04df49 to
5bfcec4
Compare
5bfcec4 to
0dfdacd
Compare
dwelle
approved these changes
Mar 10, 2025
|
When will this be deployed to pro? |
|
There are a set of changes affecting all arrow related functionality in the works which need to marinate a little on excalidraw.com before E+ merge, so stay tuned. |
|
Can you give a vague timescale? |
|
I expect it will be on E+ this week. |
|
@robmcphers0n now released! |
|
Legitimately game-changing stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dragging elbow arrows (not start or end points!) still attempts to bind, which this PR changes to no binding in drag.
Currently elbow arrows also re-bind the opposite endpoint when the other endpoint is dragged, which can rebind to the incorrect element with overlapping binding gaps.
Also fixes #9130