Skip to content

fix: duplicating/removing frame while children selected #9079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

fix: duplicating/removing frame while children selected #9079

merged 3 commits into from
Feb 4, 2025

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jan 31, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:05pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:05pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:05pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 6:05pm

@github-actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.88% (🎯 60%) 68720 / 102749
🟢 Statements 66.88% (🎯 60%) 68720 / 102749
🟢 Functions 63.72% (🎯 63%) 1962 / 3079
🟢 Branches 79.87% (🎯 70%) 8323 / 10420
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/constants.ts 99.56% 66.66% 100% 99.56% 11-12
packages/excalidraw/utility-types.ts 0% 0% 0% 0% 1-70
packages/excalidraw/utils.ts 78.31% 86.31% 75.28% 78.31% 87-89, 104-105, 141-143, 157-167, 174-179, 183-185, 187-189, 194-196, 279-280, 314, 342-355, 358-365, 368-372, 401, 409, 412, 422-425, 473, 497-502, 510-511, 528-529, 573-589, 592-596, 600-613, 627-629, 631-632, 635-636, 639-647, 650-653, 709-729, 736, 739-745, 785-786, 813, 857-863, 868-885, 897-903, 932-945, 949-950, 996-1006, 1017-1018, 1085-1086, 1094-1124, 1181-1186
packages/excalidraw/actions/actionDeleteSelected.tsx 80.38% 81.03% 83.33% 80.38% 46-47, 86-95, 125-127, 143-153, 180-190, 210-211, 217-218, 222-238, 244, 265, 295
packages/excalidraw/actions/actionDuplicateSelection.tsx 94.81% 92.72% 85.71% 94.81% 55-70, 184-185
packages/excalidraw/element/newElement.ts 92.5% 91.22% 86.36% 92.5% 146-151, 154-161, 181-195, 213, 385, 387-390, 407-408, 540, 546-547, 562-579
packages/excalidraw/element/sortElements.ts 93.33% 94.59% 100% 93.33% 51-53, 107-111
Generated in workflow #4244 for commit 4560e10 by the Vitest Coverage Report Action

@dwelle dwelle force-pushed the dwelle/fix-frame-removal branch from 7792111 to 36c711c Compare February 4, 2025 12:36
@dwelle dwelle changed the title fix: removing frame removed selected children fix: duplicating/removing frame while children selected Feb 4, 2025
@dwelle dwelle merged commit 424e94a into master Feb 4, 2025
10 checks passed
@dwelle dwelle deleted the dwelle/fix-frame-removal branch February 4, 2025 18:23
mtolmacs pushed a commit that referenced this pull request Feb 6, 2025
@dwelle @mtolmacs
fix: duplicating/removing frame while children selected (#9079)
4bccf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwelle