Skip to content

fix: hyperlinks html entities #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: hyperlinks html entities #9063

merged 1 commit into from
Jan 29, 2025

Conversation

@dwelle
Copy link
Member

@dwelle dwelle commented Jan 29, 2025

fix #9051

(the overly strict sanitization of HTML entities was unnecessary)

@vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 29, 2025 5:54pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 29, 2025 5:54pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 29, 2025 5:54pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 29, 2025 5:54pm

@dwelle dwelle mentioned this pull request Jan 29, 2025
Closed
@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.67% (🎯 60%) 68275 / 102397
🟢 Statements 66.67% (🎯 60%) 68275 / 102397
🟢 Functions 63.62% (🎯 63%) 1957 / 3076
🟢 Branches 79.31% (🎯 70%) 8169 / 10300
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/utils.ts 78.13% 86.02% 74.71% 78.13% 83-85, 100-101, 137-139, 153-163, 170-175, 179-181, 183-185, 190-192, 275-276, 310, 338-351, 354-361, 364-368, 397, 405, 408, 418-421, 469, 493-498, 506-507, 524-525, 566-582, 585-589, 593-606, 620-622, 624-625, 628-629, 632-640, 643-646, 702-722, 729, 732-738, 778-779, 806, 850-856, 861-878, 890-896, 925-938, 942-943, 989-999, 1010-1011, 1078-1079, 1087-1117, 1174-1179
packages/excalidraw/data/url.ts 44.44% 50% 33.33% 44.44% 7-8, 13-14, 21-36
packages/excalidraw/element/embeddable.ts 31.53% 20% 42.85% 31.53% 84-85, 88-281, 284-318, 326-345, 359-376, 386-387, 391-392, 396-397, 400-401, 405-406, 416-417, 419-441
Generated in workflow #4194 for commit 85b2608 by the Vitest Coverage Report Action

@dwelle dwelle merged commit a3e1619 into master Jan 29, 2025
10 checks passed
@dwelle dwelle deleted the dwelle/revert-strict-html-attr-sanit branch January 29, 2025 18:02
mtolmacs pushed a commit that referenced this pull request Feb 6, 2025
@dwelle @mtolmacs
fix: hyperlinks html entities (#9063)
8e85fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Add Link feature changed my redicrect to link

2 participants

@dwelle