feat: improve library sidebar performance #9060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
Checking, the PNG is in fact indeed perceptibly slower when compared to production. It also has a race condition with font loading (strange) where it sometimes happens that the library item's fonts (e.g. Excalifont) isn't loaded in time of render. And it's less sharp as well :(. So I'm thinking about skipping the SVG -> PNG part, unless we at least solve the 1) performance 2) fonts issues. (Also note that using |
|
Alright, I removed the PNG renderer for now and we'll see if we can reintroduce it later. Thanks for the PR! |
dwelle
approved these changes
Jan 30, 2025
mtolmacs
pushed a commit
that referenced
this pull request
Feb 6, 2025
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
mtolmacs
pushed a commit
that referenced
this pull request
Feb 11, 2025
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
mtolmacs
pushed a commit
that referenced
this pull request
Feb 20, 2025
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things: